Added translator for constants. #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangzhhui
reviewed
Dec 15, 2019
|
就是那个翻译的组件，key 中间加空格也ok得
发自我的iPhone
…------------------ Original ------------------
From: 黄朝晖 <notifications@github.com>
Date: Sun,Dec 15,2019 11:10 AM
To: hyperf/hyperf <hyperf@noreply.github.com>
Cc: 李铭昕 <l@hyperf.io>, Author <author@noreply.github.com>
Subject: Re: [hyperf/hyperf] Added translator for constants. (#1137)
@huangzhhui commented on this pull request.
In src/constants/tests/Stub/ErrorCodeStub.php:
@@ -33,4 +33,14 @@ class ErrorCodeStub extends AbstractConstants * @message("Params[%s] is invalid.") */ const PARAMS_INVALID = 503; + + /** + * @message("error.message") + */ + const TRANSLATOR_ERROR_MESSAGE = 504; + + /** + * @message("error.not exist")
这里的空格怎么理解？
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
chunhei2008
reviewed
Dec 31, 2019
|
|
||
| // 1.2 版本以下 可以使用以下方式，但会在 1.2 版本移除 | ||
|
|
||
| $message = ErrorCode::getMessage(ErrorCode::PARAMS_INVALID, 'user_id'); |
There was a problem hiding this comment.
这里意思是以后不再使用字符串格式化的方式来作为占位符了
There was a problem hiding this comment.
使用 字符串，但不再使用 ...$arguments 模式
There was a problem hiding this comment.
可以这么写
$message = ErrorCode::getMessage(ErrorCode::PARAMS_INVALID, ['user_id']);
huangzhhui
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1112