增强 retry()
#4021
Merged
增强 retry()
#4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 增加 `$when` 参数，支持忽略异常 - 增加 `$attempts` 至回调方法 `$callback`
|
这个就不增加了。。写一个作为自己常用的函数吧 |
|
when 功能去掉吧，attempts 这个我觉得可以保留 |
好 |
limingxinleo
reviewed
Sep 6, 2021
应该是从 1 开始，我理解的是执行次数，retry 进来就是 1 次了。 |
|
retry 1 实际上是会执行两次，代表重试1次 那attempts第二次，就会返回2？ 我觉得是不是跟，retry的入参对应比较好，attempts 改成 retryCount ，然后从0开始记录？ 这个让 @huangzhhui @Reasno 也看一下 |
|
不着急合并 |
OK |
|
当然，如果命名是attemps，那从1开始记录，还是挺合适的，我觉得都可以，让其他人也看一下吧 @huangdijia |
|
使用 attempts |
|
使用 retryCount |
|
投个票 |
|
@huangzhhui 就是现在的模式么？ |
limingxinleo
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$attempts至回调方法$callback