Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed return statusCode via handle method. #6004

Merged
merged 14 commits into from
Aug 9, 2023

Conversation

szutoutou
Copy link
Contributor

@szutoutou szutoutou commented Aug 8, 2023

php bin/hyperf.php foo:bar # Throws the exception that code is 0
echo $? # Output 0

@huangdijia huangdijia requested a review from limingxinleo August 8, 2023 11:56
@limingxinleo
Copy link
Member

changelog 写一下

@huangdijia
Copy link
Member

huangdijia commented Aug 8, 2023

https://www.cyberciti.biz/faq/bash-get-exit-code-of-command/

https://tldp.org/LDP/abs/html/exitcodes.html

exit status 的范围是 0~255,直接返回异常的code,可能会超出范围,-1 也不合适。

@huangdijia huangdijia changed the title fix(command):exception exitCode default -1 Allowed return statusCode via handle method. Aug 8, 2023
@huangdijia huangdijia requested a review from assert6 August 9, 2023 00:14
limingxinleo
limingxinleo previously approved these changes Aug 9, 2023
limingxinleo
limingxinleo previously approved these changes Aug 9, 2023
@limingxinleo limingxinleo merged commit 4fe3bd0 into hyperf:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants