Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized server start. #904

Merged
merged 5 commits into from
Nov 9, 2019
Merged

Optimized server start. #904

merged 5 commits into from
Nov 9, 2019

Conversation

limingxinleo
Copy link
Member

@limingxinleo limingxinleo commented Nov 9, 2019 •
edited
Loading

Server启动前再设置协程的Hook Flags，因为如果用户监听了某些事件，比如 BeforeMainServerStart 等 Server还未启动时候的事件，并且在其中使用了 IO 方法，就会导致 非协程环境使用 协程 API的BUG。

所以这里把设置 Hook Flags 的方法放到 configure serverConfig 后面，让用户可以在非协程环境下使用非协程API

@limingxinleo limingxinleo changed the title Optimized command start. Optimized server start. Nov 9, 2019
@limingxinleo limingxinleo reopened this Nov 9, 2019
@limingxinleo limingxinleo merged commit 8878b9b into hyperf:master Nov 9, 2019
@limingxinleo limingxinleo deleted the 1.1-server branch November 9, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangzhhui huangzhhui huangzhhui approved these changes

@daydaygo daydaygo Awaiting requested review from daydaygo

@Reasno Reasno Awaiting requested review from Reasno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limingxinleo @huangzhhui