Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content-Disposition header #561

Closed
mikedilger opened this issue Jun 10, 2015 · 1 comment · Fixed by #680
Closed

Content-Disposition header #561

mikedilger opened this issue Jun 10, 2015 · 1 comment · Fixed by #680
Labels
A-headers Area: headers. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@mikedilger
Copy link
Contributor

Not strictly part of HTTP/1.1 but comes up in common usage.
See:

(I'm just documenting this. I'm creating a heavily stripped down variant for my multipart/form-data parsing, and don't need a proper one at present).
@seanmonstar seanmonstar added A-headers Area: headers. E-easy Effort: easy. A task that would be a great starting point for a new contributor. labels Jun 12, 2015
@mikedilger
Copy link
Contributor Author

If anyone takes this on, you might want to start with the one at https://github.com/mikedilger/formdata/blob/master/src/headers.rs and then extend it to comply with the standards listed above.

mikedilger added a commit to mikedilger/hyper that referenced this issue Nov 10, 2015
@mikedilger
feat(headers): Add Content-Disposition header
1e6e7de 
fixes hyperium#561
mikedilger added a commit to mikedilger/hyper that referenced this issue Nov 11, 2015
@mikedilger
feat(headers): Add Content-Disposition header
d81fffa 
fixes hyperium#561
@mikedilger mikedilger mentioned this issue Nov 11, 2015
Merged
mikedilger added a commit to mikedilger/hyper that referenced this issue Nov 22, 2015
@mikedilger
feat(headers): Add Content-Disposition header
8568844 
fixes hyperium#561
mikedilger added a commit to mikedilger/hyper that referenced this issue Nov 23, 2015
@mikedilger
feat(headers): Add Content-Disposition header
7623ecc 
fixes hyperium#561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-headers Area: headers. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(headers): Add Content-Disposition header mikedilger/hyper
2 participants
@seanmonstar @mikedilger