feat(http2): set Content-Length on outgoing messages #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The server tests are ignored because they depend on #1546. We can either leave this open or fix them later. |
seanmonstar
reviewed
Jun 8, 2018
tests/server.rs
Outdated
| client | ||
| .get(uri) | ||
| .and_then(|res| { | ||
| assert_eq!(res.body().content_length(), Some(13)); |
There was a problem hiding this comment.
At least the header can be checked for, right? assert_eq!(res.headers()["content-length"], "13").
With that, these #[ignore]s could be removed, and just the checking of res.body().content_length() could be commented out with a TODO.
lnicola
force-pushed
the
h2-outgoing-length
branch
from
81a59fe
to
f537058
Compare
lnicola
force-pushed
the
h2-outgoing-length
branch
from
f537058
to
5b7c7c2
Compare
|
Excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1547