feat(client): adds HttpInfo to responses when HttpConnector is used
#1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
client-transport-extra
branch
from
bcee4d6
to
18015ca
Compare
seanmonstar
force-pushed
the
client-transport-extra
branch
from
18015ca
to
37df3d9
Compare
hawkw
added a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Jul 10, 2018
|
Anything blocking this? |
|
@sfackler I'd been waiting on the work in Linkerd to test it out before merging, in case there were any changes needed. It also allows for people to tell me it's a good or stupid idea :D |
|
This seems pretty reasonable to me API wise. I actually have a FIXME in some code to attach the remote address to our Zipkin tracing info that this feature would support. :) |
|
@seanmonstar how long do you think it'll be for this to steep? I want to take a crack at seanmonstar/warp#9 which I believe is ultimately blocked on this. |
|
This is a PR for the client, so I don't think it will help with that feature in warp... |
|
Serves me right for the very quick search and glance... |
seanmonstar
force-pushed
the
client-transport-extra
branch
from
37df3d9
to
83b4997
Compare
- Adds `client::connect::Connected::extra()`, which allows connectors to specify arbitrary custom information about a connected transport. If a connector provides this extra value, it will be set in the `Response` extensions. Closes #1402
seanmonstar
force-pushed
the
client-transport-extra
branch
from
83b4997
to
ab8d2af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client::connect::Connected::extra(), which allows connectors tospecify arbitrary custom information about a connected transport.
If a connector provides this extra value, it will be set in the
Responseextensions.Closes #1402
This is an alternative to #1592