feat(client): add conn::Builder::max_buf_size()
#1751
Conversation
src/client/conn.rs
Outdated
| @@ -75,6 +75,7 @@ pub struct Builder { | |||
| h1_writev: bool, | |||
| h1_title_case_headers: bool, | |||
| h1_read_buf_exact_size: Option<usize>, | |||
| max_buf_size: Option<usize>, | |||
There was a problem hiding this comment.
Since it's specific to HTTP1, what if the name were prefixed with h1_, like the others?
src/client/conn.rs
Outdated
| /// # Panics | ||
| /// | ||
| /// The minimum value allowed is 8192. This method panics if the passed `max` is less than the minimum. | ||
| pub fn max_buf_size(&mut self, max: usize) -> &mut Self { |
There was a problem hiding this comment.
Since it's HTTP1 only, perhaps the method should be prefixed with http1_, like the other builder methods in client/mod.rs.
src/client/conn.rs
Outdated
|
|
||
| /// Set the maximum buffer size for the connection. | ||
| /// | ||
| /// Default is ~400kb. |
There was a problem hiding this comment.
We should probably document that setting this option conflicts with setting the http1_read_buf_exact_size option.
|
Sorry. I think I merged things into my PR incorrectly. If need be I can close this PR and reopen only with my changes applied to a fresh fork. Anyway, your requested changes all make a lot of sense and I have applied them. There's one thing you brought to light that we may need to think a little bit more about. With this set of changes if a user sets both of the options regarding buffer sizes, the max buffer size will override the exact buffer size regardless of the order in which they are set. I added notes to the documentation for both options, but we may want to think about making it impossible to set both of these options at the same time by using an enum or an assertion. |
You don't need to close the PR, you can simply run the command
What about just modifying the |
This allows users to configure a limit to client connections' read and write buffers. Closes hyperium#1748
|
Didn't think of that! That seems to be the best option. |
This allows users to configure a limit to client connections' read and
write buffers.
Closes #1748