Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_buf_size setting in the server::Builder #1761

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

luben
Copy link
Contributor

@luben luben commented Feb 11, 2019

Similarly to client::Builder::http1_max_buf_size

I am not sure for the name, should it be http1_max_buf_size or it applies to both h1 and h2?

@luben luben changed the title Expose the protocol max_buf_size setting in the server::Builder Add max_buf_size setting in the server::Builder Feb 11, 2019
@luben
Copy link
Contributor Author

luben commented Feb 11, 2019

Changed the commit message to fit the limits and force pushed it in my branch to update the PR.

@seanmonstar
Copy link
Member

Hm, good point, it only applies to the HTTP1 buffer, so it should probably be prefixed with http1_.

@luben
Copy link
Contributor Author

luben commented Feb 11, 2019

I will push the name change in a minute

Similaraly to client::Builder::http1_max_buf_size
@seanmonstar
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants