Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): backport the split server conn modules #3102

Merged

Conversation

oddgrd
Copy link
Contributor

@oddgrd oddgrd commented Dec 27, 2022

This PR backports the server::conn::http1 and server::conn::http2 modules to 0.14.x. I've drew a lot on the work already done in #3063 (:pray:), but diverged a bit on the feature naming (no strong feelings on this though). I also implemented the deprecated feature flag as was suggested in that PR.

I have a couple of questions:

  • I cut out the common::time::Timer (as is done in split client conn backports), is that OK or should that module also be backported?
  • How many tests should be backported? I've started with only one for each protocol, but I'm happy to add more.

I've also only added one deprecation warning so far, but I'll look around and see if more make sense.

Closes #3079

@seanmonstar
Copy link
Member

Since I just reviewed #3101, I'm realizing that probably should be part of the backport too, or else we'll need to have deprecated methods in the backport 😅

@oddgrd
Copy link
Contributor Author

oddgrd commented Dec 27, 2022

Indeed! I'll incorporate their changes tomorrow.

src/server/conn.rs Outdated Show resolved Hide resolved
@oddgrd oddgrd force-pushed the feat/backport-split-server-conn-modules branch from 956968e to a71c219 Compare March 7, 2023 22:01
@oddgrd oddgrd force-pushed the feat/backport-split-server-conn-modules branch from a71c219 to 4504698 Compare March 7, 2023 22:06
@seanmonstar seanmonstar merged commit 84881c9 into hyperium:0.14.x Mar 8, 2023
@oddgrd oddgrd deleted the feat/backport-split-server-conn-modules branch March 9, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants