Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Allow socket2 0.5 #3314

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Sep 17, 2023

Allows users to use socket2 0.5 version. When users want to use tokio which version is larger than 1.30, as it starts to use socket2 0.5, users depend on multiple versions of socket2, 0.4 and 0.5. According to the changelog, as hyper 0.14 seems not to be affected by the socket2's breaking changes, hyper might be able to allow users to use socket2 0.5.

@seanmonstar
Copy link
Member

MSRV was too old for 0.14.x, I've fixed that in #3320, if you want to rebase.

@tottoto
Copy link
Contributor Author

tottoto commented Sep 18, 2023

Rebased.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar seanmonstar merged commit a22c512 into hyperium:0.14.x Sep 18, 2023
19 checks passed
@tottoto tottoto deleted the allow-socket2-0.5 branch September 18, 2023 20:38
@tottoto tottoto mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants