Updates for rust-openssl 0.6.0

[markuskobler]

No description provided.

[GitCop]

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

• Commit: 80176c6
  • Commits must be in the following format: %{type}(%{scope}): %{description}
• Commit: 20178be
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

---

This message was auto-generated by https://gitcop.com

[paulosuzart]

@markuskobler will you try again? Just hit the same error.

[markuskobler]

@paulosuzart Are you hitting the error below, because apparently its working by design.

native library openssl is being linked to by more than one package, and can only be linked to by one package

Their might be a better way but I got round it by using a submodule to checkout rust-openssl and then had a .cargo/config like this.

paths = [
      "vendor/hyper",
      "vendor/openssl"
]

[reem]

Maybe we want to change the signature of this function to return HttpResult so that we can use From instead of map_err(lift_ssl_error).

[markuskobler]

Happy to change that as well but that would be the first use of HttpResult net.rs

[reem]

I think we should, so that we can keep the entire error around rather than losing information like we do now.

[seanmonstar]

If that's what we want, it can be in a separate PR. Although, with the io::Error changes to holding a Box<Error>, the original SSL error is no longer really lost. It's boxed into a trait object.

[markuskobler]

So had you envisaged adding adding a new HttpSslError(SslError) to the HttpError enum?

[markuskobler]

I think you also need to change the NetworkConnector::connect and NetworkListener::accept signatures?

[paulosuzart]

@markuskobler your fix are pertinent and useful. I tried to fix myself and ended up fixing exactly the way you did. Before submit my PR I found yours. So if you just fix your commit messages they might be accepted.

[markuskobler]

@paulosuzart Sorry now I understand. So I thought my rebase markuskobler@660a362 fixed the gitcop warning.

I think it just needs someone to kick off the travis build again now that it looks like cookie-rs has been upgraded to the latest rust openssl.

[seanmonstar]

Just restarted travis.

[seanmonstar]

Thanks for this!