fix(http): fix HttpTooLagreError on TCP close #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When TCP connection finished, NetworkStream::read returns Ok(0), so buffer::read_info_buf() also returns Ok(0), but parse function treats it as the HttpTooLargeError and we have annoying errors in debug mode. We should return some kind of Err() in read_info_buf and check this error in parse function instead of treating Ok(0) as error.
When NetworkStream reads zero-length data, it treats as TCP FIN. HttpError::HttpClosed is passed through the stack and is terminated in handle_connection function.
hoxnox
force-pushed
the
bugfix_HttpTooLargeError_on_tcp_close
branch
from
e944f8d
to
e00cd19
Compare
|
Ohh! Thank you for this, now I see the issue. |
|
I handled this a little differently, by using an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TCP connection finished, NetworkStream::read returns Ok(0), so
buffer::read_info_buf() also returns Ok(0), but parse function treats
it as the HttpTooLargeError and we have annoying errors in debug mode.
We should return some kind of Err() in read_info_buf and check this
error in parse function instead of treating Ok(0) as error.