fix(server): join on thread when Listening drops #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| } | ||
|
|
||
| impl Listening { | ||
| /// Stop the server from listening to its socket address. | ||
| pub fn close(&mut self) -> HttpResult<()> { |
There was a problem hiding this comment.
This function should probably take the guard for now, so that it at least lets you close a program running a server.
seanmonstar
force-pushed
the
server-spawn
branch
from
b7ecdf5
to
d1d9dbf
Compare
|
updated |
| /// The socket addresses that the server is bound to. | ||
| pub socket: SocketAddr, | ||
| } | ||
|
|
||
| impl Drop for Listening { | ||
| fn drop(&mut self) { | ||
| match self._guard.take() { |
There was a problem hiding this comment.
much shorter to just write self._guard.take().map(|g| let _ = g.join());
seanmonstar
force-pushed
the
server-spawn
branch
from
d1d9dbf
to
68d4d63
Compare
|
updated again |
reem
added a commit
that referenced
this pull request
Apr 15, 2015
fix(server): join on thread when Listening drops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #447