fix(transport): Fix infinite recursion in poll_ready
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b90c340 (feat(transport): Allow custom IO and UDS example (#184), 2019-12-13) changed the Connector type to be more generic instead of only allowing the HttpConnector type, during this change the `Service::poll_ready` impl was changed from calling `MakeConnection::poll_ready` on `self.http` to `self` resulting in infinite recursion due to the blanket imple of `MakeConnection::poll_ready` calling `Service::poll_ready`. This fixes the bug by calling `MakeConnection::poll_ready` on `self.inner` instead of `self`. Fixes #191
LucioFranco
approved these changes
Dec 15, 2019
LucioFranco
changed the title
poll_ready
rabbitinspace
pushed a commit
to satelit-project/tonic
that referenced
this pull request
Jan 1, 2020
b90c340 (feat(transport): Allow custom IO and UDS example (hyperium#184), 2019-12-13) changed the Connector type to be more generic instead of only allowing the HttpConnector type, during this change the `Service::poll_ready` impl was changed from calling `MakeConnection::poll_ready` on `self.http` to `self` resulting in infinite recursion due to the blanket imple of `MakeConnection::poll_ready` calling `Service::poll_ready`. This fixes the bug by calling `MakeConnection::poll_ready` on `self.inner` instead of `self`. Fixes hyperium#191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b90c340 (feat(transport): Allow custom IO and UDS example (#184),
2019-12-13) changed the Connector type to be more generic instead of
only allowing the HttpConnector type, during this change the
Service::poll_readyimpl was changed from callingMakeConnection::poll_readyonself.httptoselfresulting ininfinite recursion due to the blanket imple of
MakeConnection::poll_readycallingService::poll_ready.This fixes the bug by calling
MakeConnection::poll_readyonself.innerinstead ofself.Fixes #191