Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): Fix infinite recursion in poll_ready #192

Merged
merged 1 commit into from
Dec 15, 2019
Merged

fix(transport): Fix infinite recursion in poll_ready #192

merged 1 commit into from
Dec 15, 2019

Commits on Dec 15, 2019

  1. connector: fix infinite recursion in poll_ready

    b90c340 (feat(transport): Allow custom IO and UDS example (#184),
    2019-12-13) changed the Connector type to be more generic instead of
    only allowing the HttpConnector type, during this change the
    `Service::poll_ready` impl was changed from calling
    `MakeConnection::poll_ready` on `self.http` to `self` resulting in
    infinite recursion due to the blanket imple of
    `MakeConnection::poll_ready` calling `Service::poll_ready`.
    
    This fixes the bug by calling `MakeConnection::poll_ready` on
    `self.inner` instead of `self`.
    
    Fixes #191
    bmwill committed Dec 15, 2019
    Configuration menu
    Copy the full SHA
    892aa92 View commit details
    Browse the repository at this point in the history