Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tonic-health: commit generated code #1065

Merged
merged 3 commits into from
Aug 23, 2022
Merged

tonic-health: commit generated code #1065

merged 3 commits into from
Aug 23, 2022

Commits on Aug 21, 2022

  1. tonic-health: commit generated code rather than generating at build time 

    This saves users from needing protoc available on their path if they're not
generating other tonic code at build time, either.

The generated modules can be regenerated by enabling the `gen-proto`
feature, which will trigger the relevant part of the build script.
    @sd2k
    sd2k committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    bb37fe8 View commit details
    Browse the repository at this point in the history

  2. Check generated code for tonic-health matches in CI

    @sd2k
    sd2k committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    6c25cdf View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Use bootstrap test to generate/check validity of generated code 

    As suggested by @LucioFranco in https://github.com/hyperium/tonic/pull/1065\#discussion_r951580189.
This avoids the need for a feature which would show
up in docs.rs, and achieves the same goals via CI.
    @sd2k
    sd2k committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    cb2eede View commit details
    Browse the repository at this point in the history