feat(types): Add gRPC Richer Error Model support (Help) #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following implementation at flemosr/tonic-richer-error.
LucioFranco
reviewed
Feb 23, 2023
| @@ -103,7 +109,7 @@ impl ErrorDetails { | |||
| /// QuotaViolation::new("subject 2", "description 2"), | |||
| /// ]); | |||
| /// ``` | |||
| pub fn with_quota_failure(violations: Vec<QuotaViolation>) -> Self { | |||
| pub fn with_quota_failure(violations: impl Into<Vec<QuotaViolation>>) -> Self { | |||
There was a problem hiding this comment.
FYI these are breaking changes but should be fine since I merge this PR I will release a breaking change.
There was a problem hiding this comment.
Should we take this opportunity to remove the cloning operations from the ErrorDetails getters (like ErrorDetails::bad_request)? I could do this pushing a commit to #1295, or include this change in the next PR.
There was a problem hiding this comment.
Yeah, if its a breaking change lets get it in, id like to make a breaking change release for tonic soon.
LucioFranco
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The gRPC Richer Error Model is quite useful to send additional feedback to clients, and is supported by many gRPC libraries in other languages.
Solution
This PR continues the work initiated in #1068, building on the changes made in #1282. It adds support for the
Helpstandard error message type totonic-types.