tonic-build: Allow setting skip_protoc_run on the prost Builder #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
approved these changes
Mar 20, 2023
pruthvikar
force-pushed
the
feature/allow_skip_protoc
branch
from
1f97489
to
e54d2e8
Compare
|
#1326 will fix CI for you, so once that is merged should be able to rebase and get green ci |
|
Its been merged you can reabase and CI should work. |
pruthvikar
force-pushed
the
feature/allow_skip_protoc
branch
from
e54d2e8
to
5552647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
prost-buildhas a configuration option calledskip_protoc_runthat prevents runningprotoc. This option is not exposed intonic-build. The option can be used to runprotocexternally or to use an alternative likeprotox.Solution
This PR adds the option to set
skip_protoc_runwhich is passed on to theprost-buildconfiguration.