Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(transport) Re-export axum::Router as AxumRouter #1483

Merged
merged 4 commits into from
Sep 1, 2023
Merged

chore(transport) Re-export axum::Router as AxumRouter #1483

merged 4 commits into from
Sep 1, 2023

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Aug 28, 2023

Resolves #1479.

@tottoto
Copy link
Collaborator Author

tottoto commented Aug 28, 2023

The failed codegen ci would be fixed in #1484.

@tottoto tottoto force-pushed the re-export-axum-router branch from a83269e to eb1aa0e Compare August 29, 2023 16:20
@tottoto tottoto changed the title chore(tonic) Re-export axum::Router as AxumRouter chore(transport) Re-export axum::Router as AxumRouter Aug 29, 2023
@tottoto
Copy link
Collaborator Author

tottoto commented Aug 29, 2023

As I found that axum::Router returned by tonic's Router::into_router uses axum::body::BoxBody, it might be useful to re-export axum's BoxBody as well.

@tottoto tottoto force-pushed the re-export-axum-router branch from d3ed9a0 to fa5d8b3 Compare August 29, 2023 16:27
@LucioFranco LucioFranco added this pull request to the merge queue Sep 1, 2023
Merged via the queue into hyperium:master with commit 6db46e0 Sep 1, 2023
@tottoto tottoto deleted the re-export-axum-router branch September 1, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-export axum::Router
2 participants
@tottoto @LucioFranco