feat(build): Reexport types related to prost #1925
Conversation
tonic-build/src/lib.rs
Outdated
| #[cfg(feature = "prost")] | ||
| pub use prost_build::Config as ProstBuildConfig; | ||
| #[cfg(feature = "prost")] | ||
| pub use prost_types::FileDescriptorSet; |
There was a problem hiding this comment.
Are these already used in tonic-build's public API? Where/how?
There was a problem hiding this comment.
prost_build::Config is used by compile_{protos, fds}_with_config builder APIs and prost_types::FileDescriptorSet is used by compile_fds{_with_config} builder APIs.
There was a problem hiding this comment.
Given that Config is used as Config in those functions and given that there is no type definition called Config anywhere in the tonic repo, IMO it would be clearer to just import Config without aliasing it.
There was a problem hiding this comment.
Looking at the current API, it can be interpreted that prost_build::Config is adopted as the config for tonic-build, so there seems to be no misunderstanding if tonic-build reexport it as Config. Changed to reexport prost_build::Config as Config.
tottoto
force-pushed
the
reexport-types-related-to-prost
branch
from
4050277
to
f000285
Compare
Reexports types which are used with builder based on
prost.