chore(doc): Add document about how prost-build config is used #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Sep 6, 2024
tonic-build/src/prost.rs
Outdated
| /// Compile the .proto files and execute code generation using a | ||
| /// custom `prost_build::Config`. | ||
| /// Compile the .proto files and execute code generation using a custom | ||
| /// `prost_build::Config`. The provided config will be updated by this builder's config. |
There was a problem hiding this comment.
Nit: suggest replacing "by" with "with" (also for the other method).
There was a problem hiding this comment.
Applied the suggestion.
tottoto
force-pushed
the
add-doc-about-prost-build-config
branch
from
cab5dac
to
8984e43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds document about how
prost-build's config is used.