Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Fix missing argument in generate_connect #95

Merged
merged 1 commit into from
Oct 23, 2019
Merged

fix(build): Fix missing argument in generate_connect #95

merged 1 commit into from
Oct 23, 2019

Conversation

daniel5151
Copy link
Contributor

Motivation

Closes #94.

It's literally a single line edit, so might as just do it myself 😄

Solution

Fixes generate_connect's method signature when the "transport" feature is disabled.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@LucioFranco LucioFranco changed the title fix signature when transport feature is disabled fix(build): Fix missing argument in generate_connect Oct 23, 2019
@LucioFranco LucioFranco merged commit eea3c0f into hyperium:master Oct 23, 2019
@LucioFranco
Copy link
Member

@daniel5151 is this something you would like released asap or can you live off of git for a bit?

@daniel5151
Copy link
Contributor Author

daniel5151 commented Oct 23, 2019

Nope, no rush!

On a somewhat related note, I encountered this issue while tinkering with an implementation of GrpcService that works over unix sockets (to communicate with containerd). I don't think i'll actually be pursuing it though (I found a bodge that should get the job done for now), but I am keeping an eye on #31 👀

@daniel5151 daniel5151 deleted the tonic-build-notransport-fix branch October 23, 2019 21:58
@LucioFranco
Copy link
Member

@daniel5151 I'd suggest using https://docs.rs/hyper/0.13.0-alpha.4/hyper/client/service/struct.Connect.html where the inner C type is a tower_service::Service that returns a UDS instead of a TCPStream.

@daniel5151
Copy link
Contributor Author

Yeah, that would be the Right Way to do it, through it turns into a bit of a yak-shave, since hyperlocal hasn't been updated for 0.13 yet, so I'd have to port it forward.

@LucioFranco
Copy link
Member

Yeah, sorry there are a bunch of changes in flux we should be settling very soon!

rabbitinspace pushed a commit to satelit-project/tonic that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tokio-build fails with "transport" feature disabled
2 participants