Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Allow user to decide to deploy a trusted relayer ISM #4464

Closed
ltyu opened this issue Sep 9, 2024 · 0 comments · Fixed by #4504
Closed

feat(cli): Allow user to decide to deploy a trusted relayer ISM #4464

ltyu opened this issue Sep 9, 2024 · 0 comments · Fixed by #4504
Assignees
@xeno097
Labels
CLI

Comments

@ltyu
Copy link
Contributor

ltyu commented Sep 9, 2024 •
edited
Loading

Problem

Currently in the CLI command: hyperlane warp init, we initialize a trustedRelayerIsm in the config. This means that deployments will include a trusted relayer ism that is not useful outside of self-relaying. To go to production, we generally ask to remove this ISM. This is problematic because this can be an extra step that wastes time and gas.

Solution

  • Let the user pick whether they want to potentially deploy a trustedRelayerIsm
  • a user should skip this prompt through --yes
  • Update relevant docs for this

Additional context

https://discord.com/channels/935678348330434570/1280579302773227571
@ltyu ltyu added the CLI label Sep 9, 2024
@xeno097 xeno097 mentioned this issue Sep 17, 2024
Merged
@ltyu ltyu closed this as completed Oct 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperlane Tasks Oct 8, 2024
@jmrossy jmrossy removed this from Hyperlane Tasks Oct 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 15, 2024
@xeno097 @ltyu
feat: warp init simplified config (#4504)
3662297 
### Description

This PR updates the ISM configuration prompting for the `warp init`
command allowing the user to choose if a trusted ISM should be used by
default or a configured one.

Before:

![image](https://github.com/user-attachments/assets/7be4e5af-d664-4481-ac31-b87caf609b91)


![image](https://github.com/user-attachments/assets/030aa59c-82ad-4349-a973-273b0eb15403)

After:

![image](https://github.com/user-attachments/assets/c19ca765-c771-4d04-8041-c5c19f44f645)


![image](https://github.com/user-attachments/assets/5e875beb-c86e-464d-bcf9-0c705a9f43ce)


### Drive-by changes

- No

### Related issues

- Fixes #4464

### Backward compatibility

- Yes

### Testing

- Manual

---------

Co-authored-by: Lee <6251863+ltyu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xeno097 xeno097

Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: warp init simplified config hyperlane-xyz/hyperlane-monorepo
2 participants
@ltyu @xeno097