Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warp init simplified config #4504

Merged
merged 11 commits into from
Oct 15, 2024
Merged

feat: warp init simplified config #4504

merged 11 commits into from
Oct 15, 2024
+44 −10

Conversation

xeno097
Copy link
Contributor

@xeno097 xeno097 commented Sep 17, 2024

Description

This PR updates the ISM configuration prompting for the warp init command allowing the user to choose if a trusted ISM should be used by default or a configured one.

Before:
image

image

After:
image

image

Drive-by changes

  • No

Related issues

Backward compatibility

  • Yes

Testing

  • Manual

@xeno097 xeno097 requested a review from ltyu September 17, 2024 15:09
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 96ca5ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (c08d842) to head (96ca5ea).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4504   +/-   ##
=======================================
  Coverage   73.85%   73.85%           
=======================================
  Files         100      100           
  Lines        1423     1423           
  Branches      181      181           
=======================================
  Hits         1051     1051           
  Misses        351      351           
  Partials       21       21
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 75.71% <ø> (ø)
isms 78.94% <ø> (ø)
token 88.23% <ø> (ø)
middlewares 77.39% <ø> (ø)

yorhodes
yorhodes approved these changes Sep 17, 2024
View reviewed changes
typescript/cli/src/config/warp.ts Outdated Show resolved Hide resolved
yorhodes
yorhodes requested changes Sep 17, 2024
View reviewed changes
.changeset/long-swans-drive.md Outdated Show resolved Hide resolved
ltyu
ltyu reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ltyu ltyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress.
There is some conflicting (and confusing) flags that should not work together, in this case it is --advanced and --yes. One thing that can help is to force --advanced and --yes to be mutually exclusive by using conflicts

Here's where you can use it:
Screenshot 2024-09-19 at 1 46 20 PM

.changeset/long-swans-drive.md Outdated Show resolved Hide resolved
typescript/cli/src/config/warp.ts Outdated Show resolved Hide resolved
typescript/cli/src/config/warp.ts Outdated Show resolved Hide resolved
@xeno097
Copy link
Contributor Author

xeno097 commented Sep 19, 2024

Good progress. There is some conflicting (and confusing) flags that should not work together, in this case it is --advanced and --yes. One thing that can help is to force --advanced and --yes to be mutually exclusive by using conflicts

Here's where you can use it: Screenshot 2024-09-19 at 1 46 20 PM

Hey @ltyu before pushing the pr I tried the conflicts option but it fails even if the user does not provide it because we have default values for it, I implemented a manual check but changed it after a comment from @yorhodes here -> #4504 (comment). I can re-add the manual check if we want to

xeno097 and others added 2 commits September 19, 2024 14:15
@xeno097 @ltyu
fixed typo in .changeset/long-swans-drive.md
564fa86 
Co-authored-by: Lee <6251863+ltyu@users.noreply.github.com>
@xeno097 @ltyu
feat(cli): improved prompt message for default ISM in typescript/cli/…
4d23bda 
…src/config/warp.ts

Co-authored-by: Lee <6251863+ltyu@users.noreply.github.com>
@ltyu
Copy link
Contributor

ltyu commented Sep 19, 2024

Good progress. There is some conflicting (and confusing) flags that should not work together, in this case it is --advanced and --yes. One thing that can help is to force --advanced and --yes to be mutually exclusive by using conflicts
Here's where you can use it: Screenshot 2024-09-19 at 1 46 20 PM

Hey @ltyu before pushing the pr I tried the conflicts option but it fails even if the user does not provide it because we have default values for it, I implemented a manual check but changed it after a comment from @yorhodes here -> #4504 (comment). I can re-add the manual check if we want to

ah make sense. i'm okay with it being biased to one of them.

@xeno097 xeno097 requested a review from ltyu September 23, 2024 16:26
@xeno097 xeno097 requested a review from ltyu September 26, 2024 21:12
ltyu
ltyu approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ltyu ltyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xeno097 xeno097 added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 3662297 Oct 15, 2024
34 checks passed
@xeno097 xeno097 deleted the xeno/warp-route-simplified-config branch October 15, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltyu ltyu ltyu approved these changes

@yorhodes yorhodes yorhodes approved these changes

@jmrossy jmrossy Awaiting requested review from jmrossy jmrossy is a code owner

@aroralanuk aroralanuk Awaiting requested review from aroralanuk

@Skunkchain Skunkchain Awaiting requested review from Skunkchain

@avious00 avious00 Awaiting requested review from avious00

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cli): Allow user to decide to deploy a trusted relayer ISM
3 participants
@xeno097 @ltyu @yorhodes