-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update warp remote router schema #4948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min field to allow deploy overrides and checks
…hod to retrive proxy admin data
…e an already existing proxy admi ncontract for deployments
…to xeno/warp-deploy-apply-ownership-fixes
…to xeno/warp-deploy-apply-ownership-fixes
…ents and admin proxy ownership transfer in warp apply
Co-authored-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
… to core init command
…nfig defines owners fro the mailbox proxy admin adn ica router and use those values intead of the signer
…to xeno/warp-deploy-apply-ownership-fixes
…to xeno/warp-deploy-apply-ownership-fixes
…t defined on the type
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…yperlane-xyz/hyperlane-monorepo into xeno/core-deploy-apply-admin-proxy-ownership-fixes
…r the mailbox contract
…admin proxy ownership code
…ly for core command testing
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…to xeno/warp-deploy-apply-ownership-fixes
…yperlane-xyz/hyperlane-monorepo into xeno/core-deploy-apply-admin-proxy-ownership-fixes
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…github.com:hyperlane-xyz/hyperlane-monorepo into xeno/ica-router-management-update
…to xeno/ica-router-management-update
…to xeno/ica-router-management-update
…to xeno/ica-router-management-update
…to xeno/ica-router-management-update
…to xeno/ica-router-management-update
…to xeno/ica-router-management-update
…to xeno/ica-router-management-update
…to xeno/update-warp-remote-router-schema
xeno097
requested review from
jmrossy,
yorhodes,
ltyu and
paulbalaji
as code owners
December 4, 2024 21:03
🦋 Changeset detectedLatest commit: ca17ebb The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…er to the ica routing schema
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4948 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
ltyu
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Warp route remote routers schema to be closer to the remoteIcaRouters schema from core apply
Drive-by changes
Related issues
Backward compatibility
Testing