Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Google Cloud Storage CheckpointSyncer checker implementation #4971

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maximegris
Copy link

@maximegris maximegris commented Dec 9, 2024

Description

The current CLI command hyperlane avs check only checks when storage location starts with s3://

This PR allow to retrieve and check the validator state on Google Cloud Storage - when storage location starts with gs://

Drive-by changes

  • Use the latest location set during Validator registration & retrieve it from ValidatorAnnounce.getAnnouncedStorageLocations

Related issues

  • None

Backward compatibility

  • Yes

Testing

  • Manual using locally compiled yarn hyperlane avs check command

Before

Operator name: Born to be wild
Operator address: 0xd38d980188604c7051dbce2980a0c6e38423fda4
Validator address: 0x58a607f46a481c9e5209ab27f45189411fA83D41
Validator is not validating on any chain

After

Operator name: Born to be wild
Operator address: 0xd38d980188604c7051dbce2980a0c6e38423fda4
Validator address: 0x58a607f46a481c9e5209ab27f45189411fA83D41
  Validating on...
  optimism
  Storage location: https://storage.googleapis.com/hyperlane_2okiqlhes2ki6lfsgsa0qlzaclx/gcsLatestIndexKey
  Latest merkle tree checkpoint index: 632213
  Latest validator checkpoint index: 632213

Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: e00bc1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maximegris maximegris force-pushed the mg/google-storage-syncer-check branch from 54a24b6 to f0dd9d4 Compare December 9, 2024 13:46
typescript/cli/src/validator/utils.ts Outdated Show resolved Hide resolved
typescript/cli/src/validator/utils.ts Outdated Show resolved Hide resolved
typescript/cli/src/avs/check.ts Outdated Show resolved Hide resolved
typescript/cli/src/avs/check.ts Outdated Show resolved Hide resolved
@maximegris maximegris requested a review from paulbalaji December 9, 2024 14:17
@maximegris maximegris force-pushed the mg/google-storage-syncer-check branch from e00bc1d to 45f9d11 Compare December 14, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants