fix: post filter vs tag filter and int tests

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
hyperledger-archives · Jan 17, 2022 · b4ce3a2 · b4ce3a2
1 parent 0040154
commit b4ce3a2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/acapy_plugin_toolbox/holder/v0_1/messages/cred_get_list.py b/acapy_plugin_toolbox/holder/v0_1/messages/cred_get_list.py
@@ -62,7 +62,7 @@ async def handle(self, context: RequestContext, responder: BaseResponder):
         session = await context.session()
 
         credentials = await CredExRecord.query(
-            session, tag_filter={"role": CredExRecord.ROLE_HOLDER}
+            session, post_filter_positive={"role": CredExRecord.ROLE_HOLDER}
         )
 
         if self.states:

diff --git a/int/tests/test_holder.py b/int/tests/test_holder.py
@@ -187,12 +187,12 @@ async def test_credentials_get_list(
             "@type": "did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/admin-holder/0.1/credentials-get-list"
         }
     )
-    cred_set = set([result.credential_exchange_id for result in cred.results])
-    cred_get_list_set = set(
-        [cred["credential_exchange_id"] for cred in credentials_get_list["results"]]
-    )
+    cred_set = {result.credential_exchange_id for result in cred.results}
+    cred_get_list_set = {
+        cred["credential_exchange_id"] for cred in credentials_get_list["results"]
+    }
     assert (
         credentials_get_list["@type"]
         == "did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/admin-holder/0.1/credentials-list"
     )
-    assert cred_set.issubset(cred_get_list_set)
+    assert cred_get_list_set <= cred_set