Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

feat:added presentation exchange flow integration test #110

Merged

Conversation

PeterStrob
Copy link
Contributor

Signed-off-by: PeterStrob peter@indicio.tech

Signed-off-by: PeterStrob <peter@indicio.tech>
@dbluhm dbluhm requested a review from cjhowland October 29, 2021 21:04
cjhowland
cjhowland previously approved these changes Oct 29, 2021
Copy link
Contributor

@cjhowland cjhowland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Looking into the failing holder tests.

@dbluhm
Copy link
Contributor

dbluhm commented Oct 29, 2021

We'll have to fix up tests before merging but I second Char, additions look good 🙂

…ompose.yml file

Signed-off-by: PeterStrob <peter@indicio.tech>
Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last minor comments. Nice work!

int/tests/test_presentation_integration.py Outdated Show resolved Hide resolved
tests/holder/test_events.py Outdated Show resolved Hide resolved
tests/holder/test_events.py Show resolved Hide resolved
PeterStrob and others added 3 commits November 4, 2021 09:31
Signed-off-by: PeterStrob <peter@indicio.tech>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm dbluhm merged commit fd15350 into hyperledger-archives:main Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants