Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

feat: add docker-compose for agent local connections #114

Merged

Conversation

cjhowland
Copy link
Contributor

Signed-off-by: Char Howland char@indicio.tech

Signed-off-by: Char Howland <char@indicio.tech>
@dbluhm
Copy link
Contributor

dbluhm commented Dec 14, 2021

Tested on linux using the HOST_IP. I obtained which IP to use by running: docker run --rm -it --net=host eclipse/che-ip

Signed-off-by: Micah Peltier <micah6_8@yahoo.com>
@dbluhm dbluhm marked this pull request as ready for review December 14, 2021 17:43
Copy link
Contributor

@TheTechmage TheTechmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Let's get them merged. This should make development a lot easier, in fact, this should also help out when people are trying to play with it like in #98.

@TheTechmage TheTechmage merged commit 5cf814c into hyperledger-archives:main Dec 14, 2021
@cjhowland cjhowland deleted the fix/local-connections-only branch December 15, 2021 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants