This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
Feature/aca py 0.7.3rc0 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Due to changes within the *Managers in ACA-Py, I have decided that it is cleaner to not create a ProfileSession when we are calling send_to_admins when the ConnectionManager requires a base profile anyways. This has resulted in a cleaner codebase for all the places where send_to_admins is called. Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
When the request to Indicio's selfserve URL times out, it becomes a bit difficult to trace where the exception is coming from. Adding a try catch then re-raising a new error should make it easier to spot in the future. Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
cjhowland
approved these changes
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are to support the upgrade to ACA-Py 0.7.3 when it releases. For the time being, it's pointing at the release candidate's pre-release package.