This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
feat: Add revocation support to credentials #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colton Wolkins <colton@indicio.tech>
Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
dbluhm
reviewed
Sep 24, 2021
…tials Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
dbluhm
reviewed
Sep 29, 2021
Made the mistake of using a local container instead of a published one when working on revocation. dbluhm noticed this and published a container. This change uses that container. Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Just removing comments and a stray space in the docker compose file Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
dbluhm
reviewed
Sep 29, 2021
As recommended by dbluhm, the tails server tunnel has been switched to using the localtunnel docker image instead of the agent-tunnel docker image. This change also adds a new environment variable titled `TAILS_TUNNEL_HOST` which defaults to `https://localtunnel.me`. Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
TheTechmage
commented
Oct 5, 2021
There was a stray support_revocation that I had left in the initialization line of the SchemaRecord class. However, I never changed that class, so the line shouldn't have been committed in the first place. Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
dbluhm
previously approved these changes
Oct 5, 2021
Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
auto-merge was automatically disabled
October 5, 2021 22:00
Head branch was pushed to by a user without write access
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
dbluhm
approved these changes
Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running into an error saving credentials with the
support_revocationflag. Data appears to be successfully received from the client, however, saving the details is another matter. Every time the credential definition is retrieved by the toolbox,support_revocationis set tofalse(the default value).Signed-off-by: Colton Wolkins colton@indicio.tech