This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
Fix message delivery to open session #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
This short circuits session return Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
TheTechmage
suggested changes
Oct 25, 2021
There was a problem hiding this comment.
I believe the changes to Alice and Bob's config files were not intended to be changed. In Alice's config, all auto responses were switched to manual and the tails server was removed. In both, the genesis-url was switched from the Sovrin network to the Indicio network. Aside from that, I think the changes look good to me.
|
Yes, I think we want to drop the last commit. These config changes should be captured elsewhere for David's use case. |
dbluhm
force-pushed
the
fix/basicmessage-to-session
branch
from
ef7895c
to
ec6e0b3
Compare
TheTechmage
reviewed
Nov 4, 2021
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
TheTechmage
approved these changes
Nov 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging usage with mobile agents, it was discovered that there is some quirky behavior in message delivery to open sockets from the toolbox plugin. This PR fixes these quirks.