This repository has been archived by the owner on Jan 29, 2022. It is now read-only.
Update Cargo.toml to use crates for sdk #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Beck-Buysse <rbuysse@bitwise.io>
arsulegai
suggested changes
Nov 9, 2018
| @@ -22,7 +22,7 @@ log4rs = "0.8" | |||
| log4rs-syslog = "3.0" | |||
| protobuf = "2" | |||
| raft = "0.3.1" | |||
| sawtooth_sdk = { git = "https://github.com/hyperledger/sawtooth-core.git" } | |||
| sawtooth-sdk = "^0.1" | |||
There was a problem hiding this comment.
How about extern crate declaration and use statements?
I guess build might fail without that change.
There was a problem hiding this comment.
If you mean due to the crate's coordinate change (`"sawtooth_sdk" -> "sawtooth-sdk"), those don't need to change. Rust automatically translates those the dashes to the underscores.
(See rust-lang/rust#23533 for details)
There was a problem hiding this comment.
Thanks for the link. It clarifies my question.
peterschwarz
approved these changes
Nov 9, 2018
rbuysse
requested review from
aludvik,
agunde406,
boydjohnson,
dplumb94,
jsmitchell,
ltseeley,
peterschwarz,
rberg2,
vaporos and
a team
peterschwarz
approved these changes
Nov 9, 2018
arsulegai
approved these changes
Nov 10, 2018
aludvik
approved these changes
Nov 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Beck-Buysse rbuysse@bitwise.io