Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace docker-compose (V1) with docker compose (V2) #490

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Replace docker-compose (V1) with docker compose (V2) #490

merged 3 commits into from
Jun 26, 2024

Conversation

nxsaken
Copy link
Contributor

@nxsaken nxsaken commented May 22, 2024

Closes #487.

@nxsaken
Replace docker-compose (V1) with docker compose (V2)
cc0e80e 
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
@vercel Vercel
Copy link

vercel bot commented May 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
iroha-2-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 1:27pm

@nxsaken nxsaken added the L-setup First steps (installing, building, etc.) label May 22, 2024
yamkovoy
yamkovoy reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@yamkovoy yamkovoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one minor suggestion. Other than that, LGTM.

P.S.: The entire Iroha on bare metal topic should be rewritten for accessibility in the future.

src/guide/advanced/running-iroha-on-bare-metal.md Outdated Show resolved Hide resolved
@nxsaken @yamkovoy
Fix spelling in bare metal tutorial
95d438b 
Co-authored-by: yamkovoy <100563712+yamkovoy@users.noreply.github.com>
Signed-off-by: Nurzhan Saken <nurzhan.sakenov@gmail.com>
yamkovoy
yamkovoy approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@yamkovoy yamkovoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, left some leftover text in my previous suggestion.

src/guide/advanced/running-iroha-on-bare-metal.md Outdated Show resolved Hide resolved
@yamkovoy
Update src/guide/advanced/running-iroha-on-bare-metal.md
67b4f35 
Signed-off-by: yamkovoy <100563712+yamkovoy@users.noreply.github.com>
@nxsaken nxsaken merged commit c1520e4 into hyperledger-iroha:main Jun 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamkovoy yamkovoy yamkovoy approved these changes

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@WRRicht3r WRRicht3r Awaiting requested review from WRRicht3r WRRicht3r is a code owner

Assignees
No one assigned
Labels
L-setup First steps (installing, building, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace docker-compose with docker compose
2 participants
@nxsaken @yamkovoy