Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit dependency type for grpc #53

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Conversation

gunrus
Copy link

@gunrus gunrus commented Feb 21, 2020

Faced problem during configuration of jmeter-maven-plugin, it's can not collect grpc dependency because default type is 'jar' not 'pom'

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #53 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #53      +/-   ##
===========================================
- Coverage     72.85%   72.6%   -0.25%     
+ Complexity      348     345       -3     
===========================================
  Files            38      38              
  Lines          1610    1610              
  Branches         51      51              
===========================================
- Hits           1173    1169       -4     
- Misses          355     358       +3     
- Partials         82      83       +1
Impacted Files Coverage Δ Complexity Δ
...oha/java/detail/TransactionStatusObserverFace.java 18.18% <0%> (-9.1%) 2% <0%> (-1%)
...roha/java/debug/TestTransactionStatusObserver.java 50% <0%> (-5.56%) 15% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d7172...74bdf31. Read the comment docs.

Signed-off-by: ganeevnbc <ganeev@soramitsu.co.jp>

fixed grpc plugin call in build script

explicit dependency type for grpc

fixed grpc plugin call in build script

Fixed CI

Signed-off-by: Mingela <freekilluau@gmail.com>
@Mingela Mingela merged commit 6de97e1 into hyperledger-iroha:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants