Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Update executor config in the genesis block #4291

Closed
0x009922 opened this issue Feb 18, 2024 · 3 comments
Closed

[suggestion] Update executor config in the genesis block #4291

0x009922 opened this issue Feb 18, 2024 · 3 comments
Assignees
@0x009922 @alexstroke1
Labels
config-changes Changes in configuration and start up of the Iroha good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@0x009922
Copy link
Contributor

Description

TL;DR: drop inline executor support; rename field to executor_file.

Genesis block contains executor field, which might either represent an inline base64-encoded WASM blob, or a file path to the WASM blob:

https://github.com/hyperledger/iroha/blob/964476722e2a219becaacdb3676ca058ec5748cd/configs/swarm/genesis.json#L185

This is backed by the ExecutorMode struct:

https://github.com/hyperledger/iroha/blob/964476722e2a219becaacdb3676ca058ec5748cd/genesis/src/lib.rs#L122-L131

As we discussed in #4239, executor field with file path should be renamed to executor_file for uniformity.

In addition to that, I propose to remove inline executor mode. It was effectively deprecated a long time ago: there was a warning printed when the inline mode is used (cannot find references for that). The reason is that inlining WASM blob makes the whole genesis file (1) clunky and (2) hardly reproducible due to WASM compilation intricacies.
@0x009922 0x009922 added good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha labels Feb 18, 2024
This was referenced Feb 18, 2024
Merged
Closed
@mversic
Copy link
Contributor

mversic commented Feb 19, 2024

In addition to that, I propose to remove inline executor mode

yes, please

@dchidindu5
Copy link

I'd like to know if this repo is still very active

@mversic
Copy link
Contributor

mversic commented Feb 19, 2024

I'd like to know if this repo is still very active

Yes it is. You can easily verify this yourself. The main activity is on the iroha2-dev branch. If that is confusing you?

@0x009922 0x009922 self-assigned this Mar 15, 2024
0x009922 added a commit to 0x009922/iroha that referenced this issue Mar 15, 2024
@0x009922
[refactor] hyperledger-iroha#4291: update genesis config & schema
bc915d2 
- remove inline executor mode
- rename field to `executor_file`
- remove genesis from schema (revert hyperledger-iroha#1391)

Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
@0x009922 0x009922 mentioned this issue Mar 15, 2024
Merged
0x009922 added a commit to 0x009922/iroha that referenced this issue Mar 19, 2024
@0x009922
[refactor] hyperledger-iroha#4291: update genesis config & schema
d3bf74a 
- remove inline executor mode
- rename field to `executor_file`
- remove genesis from schema (revert hyperledger-iroha#1391)

Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
0x009922 added a commit to 0x009922/iroha that referenced this issue Mar 19, 2024
@0x009922
[refactor] hyperledger-iroha#4291: update genesis config & schema
3c07969 
- remove inline executor mode
- rename field to `executor_file`
- remove genesis from schema (revert hyperledger-iroha#1391)

Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
mversic pushed a commit that referenced this issue Mar 19, 2024
@0x009922
[refactor] #4291: update genesis config & schema (#4370)
c9dce26 
* [refactor] #4291: update genesis config & schema

- remove inline executor mode
- rename field to `executor_file`
- remove genesis from schema (revert #1391)

Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
@AlexStroke AlexStroke self-assigned this Mar 26, 2024
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x009922 0x009922

@alexstroke1 alexstroke1

Labels
config-changes Changes in configuration and start up of the Iroha good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dchidindu5 @0x009922 @mversic @AlexStroke @alexstroke1