-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #2689: Add permission token definition parameters #2694
Merged
Arjentix
merged 23 commits into
hyperledger-iroha:iroha2-dev
from
Arjentix:permission_token_definition_parameters
Sep 16, 2022
Merged
[feature] #2689: Add permission token definition parameters #2694
Arjentix
merged 23 commits into
hyperledger-iroha:iroha2-dev
from
Arjentix:permission_token_definition_parameters
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arjentix
added
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
api-changes
Changes in the API for client libraries
Yellow
labels
Sep 3, 2022
Arjentix
requested review from
s8sato,
appetrosyan,
mversic,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev and
Erigara
as code owners
September 3, 2022 13:54
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2694 +/- ##
==============================================
- Coverage 67.61% 65.67% -1.94%
==============================================
Files 140 166 +26
Lines 26173 29894 +3721
==============================================
+ Hits 17696 19633 +1937
- Misses 8477 10261 +1784
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
appetrosyan
reviewed
Sep 5, 2022
appetrosyan
reviewed
Sep 5, 2022
outoftardis
reviewed
Sep 5, 2022
Erigara
reviewed
Sep 5, 2022
Erigara
previously approved these changes
Sep 5, 2022
Arjentix
force-pushed
the
permission_token_definition_parameters
branch
from
September 5, 2022 13:06
b7d4479
to
1050e14
Compare
Erigara
previously approved these changes
Sep 5, 2022
appetrosyan
previously approved these changes
Sep 5, 2022
outoftardis
reviewed
Sep 5, 2022
outoftardis
reviewed
Sep 5, 2022
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
… 'origin/iroha2-dev'. Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
… 'iroha2-dev'. Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix
force-pushed
the
permission_token_definition_parameters
branch
from
September 16, 2022 08:51
57a3d29
to
f7635d2
Compare
Erigara
reviewed
Sep 16, 2022
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Erigara
reviewed
Sep 16, 2022
Erigara
approved these changes
Sep 16, 2022
appetrosyan
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
PermissionTokenDefinition
. They contain param name and param type.Grant<Account, PermissionToken
andRegister<Role>
Issue
PermissionTokenDefinition
#2689Benefits
Possible Drawbacks
API breaking change. That will hurt a little bit for SDK-developers
Usage Examples or Tests
cargo test --package iroha_client --test mod -- integration::permissions::token_parameters --nocapture