-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #3038: Re-enable multisigs #3043
[fix] #3038: Re-enable multisigs #3043
Conversation
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3043 +/- ##
==============================================
+ Coverage 62.33% 64.47% +2.13%
==============================================
Files 169 171 +2
Lines 31218 33030 +1812
==============================================
+ Hits 19459 21295 +1836
+ Misses 11759 11735 -24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this builds upon #3035, so looked only at the last commit.
Edit: sorry, didn't notice it's a draft, feel free to dismiss if it's not the final product :)
aeaaa1c
to
b2b8447
Compare
dce1888
to
02bad70
Compare
6ec9507
to
c44abe4
Compare
74ddb00
to
378c764
Compare
378c764
to
4e8f2b4
Compare
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
…ultisigs Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
4e8f2b4
to
b892ca5
Compare
Description of the Change
Queue
andSumeragi
to bring multisignatures back.We need second queue for multisigns in order to prevent situation when multisig transactions prevent ordinary transactions from being processed.
Issue
Closes #2595, #3038, #3039.
Benefits
Multisignatures are working again.
Possible Drawbacks
More complex queue.
Usage Examples or Tests
Test for multisig functionality on one peer:
cargo test --package iroha_core --lib -- queue::tests::push_multisignature_tx --exact --nocapture
Test for multisig transaction gossiping between multiple peers:
cargo test --package iroha_client --test mod -- integration::multisignature_transaction::multisignature_transactions_should_wait_for_all_signatures --exact --nocapture