-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #4063: update configuration endpoints #4076
[fix] #4063: update configuration endpoints #4076
Conversation
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Pull Request Test Coverage Report for Build 6975480014
💛 - Coveralls |
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
|
||
/// Subset of [`super::iroha`] configuration. | ||
#[derive(Debug, Serialize, Deserialize, Clone, Copy)] | ||
pub struct ConfigurationDTO { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe call it PartialConfiguration
or DynamicConfiguration
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that DTO
suffix emphasizes the purpose to use this structure to interact with the client side.
Partial
seems to be too general here (like Proxy
s we have already), while Dynamic
might semantically fit.
I think returning Docs was rather silly. Thanks Dima |
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
The logger & dynamic reloads architecture needs to be refactored first. |
Description
I've implemented the changes according to the linked issue:
Linked issue
Closes #4063
Benefits
A little step closer to implementing the Configuration RFC (#2585).
Checklist
Result<bool>
PATCH
instead ofPOST