-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #4093, #4110: Add public key mint and burn commands to iroha_client_cli
#4408
Conversation
…ient_cli` Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
… to `iroha_client_cli` Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
f263f44
to
b46fb6b
Compare
Is there a reason why minting a key for account is in the account subcommand, but burning is in an entirely new one? |
I simply went with the formats described in the respective issues. They probably should be under the same subcommand, but I wanted to get feedback first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this work will be reverted by the 1st PR for #2085 in progress, which makes an account have a single public key in its ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the issues this PR addresses are obsolete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is an unfortunate conflict, but after opening the PR I will check if the open issues are still valid
Pull Request Test Coverage Report for Build 8550778779Details
💛 - Coveralls |
Description
Linked issue
Closes #4093 and #4110.
Checklist
CONTRIBUTING.md