-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate connection profiles #248
Conversation
6e4a466
to
80e99fc
Compare
80e99fc
to
2ddb6f2
Compare
eff7dc6
to
5b1aec6
Compare
Signed-off-by: Grzegorz Hejduk <grzegorz.hejduk@softwaremill.com>
5b1aec6
to
72b3588
Compare
e2e/performTests.ts
Outdated
const testFilesContent = (commands: TestCommands, config: string, files: string[], rootPath: string) => | ||
files.forEach((f) => { | ||
it(`should create proper ${f} from ${config}`, () => { | ||
const content = commands.getFileContent(`${commands.relativeRoot}/${f}`); | ||
const cleaned = content | ||
.replace(/FABLO_BUILD=(.*?)(\n|$)/g, "FABLO_BUILD=<date with git hash>\n") | ||
.replace(/FABLO_CONFIG=(.*?)(\n|$)/g, "FABLO_CONFIG=<absolute path>\n") | ||
.replace(/CHAINCODES_BASE_DIR=(.*?)(\n|$)/g, "CHAINCODES_BASE_DIR=<absolute path>\n") | ||
.replace(/COMPOSE_PROJECT_NAME=(.*?)(\n|$)/g, "COMPOSE_PROJECT_NAME=<name with timestamp>\n"); | ||
.replace(/COMPOSE_PROJECT_NAME=(.*?)(\n|$)/g, "COMPOSE_PROJECT_NAME=<name with timestamp>\n") | ||
.replace(new RegExp(rootPath, "g"), "<absolute path>"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sprytnie z tym rootPath. Zadziała to może też na FABLO_CONFIG
i CHAINCODES_BASE_DIR
? bo jeśli tak, to bym tamte replacy proponował wywalić
druga rzecz - schowałbym ten rootPath tutaj, tzn nie jako parameter, tylko tutaj resolvował const rootPath = resolve(__dirname + "/../");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To nie zadziałało, tam były jakieś inne wartości.
@@ -0,0 +1,122 @@ | |||
import { NetworkSettings, OrgConfig, PeerConfig } from "./FabloConfigExtended"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fajnie, że w TS 👏
Signed-off-by: Grzegorz Hejduk <grzegorz.hejduk@softwaremill.com>
Hi, it is just not released yet. We plan to make a new release in the next few days, so you can just wait, or you can build Fablo from the source code. If you want to use Fablo from the source code:
|
That's perfect! Thanks very much! |
closes: #179