Install chaincode from docker image #445
Conversation
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
| @@ -12,64 +12,69 @@ dockerPullIfMissing() { | |||
| chaincodeBuild() { | |||
There was a problem hiding this comment.
I would recommend to split it into two functions:
chaincodeBuildDirPath, chaincodeBuildImage It would simplify the logic chaincode-install-v2 and would mean that we don't need to make if checks inside script
| "<%= chaincode.lang %>" <% -%> | ||
| "<%= chaincode.image %>" | ||
| "<%= global.fabricRecommendedNodeVersion %>" | ||
| <% } -%> |
There was a problem hiding this comment.
As I've written below, having two independent functions chaincodeBuildDirPath, chaincodeBuildImage would simplify this logic, thanks to it we don't need to have if statements inside functions.
There was a problem hiding this comment.
Also, to be considered - maybe it is even possible to do build->package->install if we have directory, and just a single step if we have docker image. The flow might be slightly different
There was a problem hiding this comment.
The flow for deploying Chaincode-as-a-Service is build/pull a Docker Image -> Package A Chaincode (only contains connection details) -> Install -> Run the Chaincode-as-a-service Containers.
|
Reminder for later: Remember about adding snapshots when you'll finish the task. |
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
Signed-off-by: roopsai surampudi <roopsai@outlook.in>
No description provided.