Adding logs with uber/zap #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoaebjindani
force-pushed
the
operatorLogsToUTC
branch
from
d321bad
to
844df57
Compare
shoaebjindani
force-pushed
the
operatorLogsToUTC
branch
from
3dc9032
to
647c2ec
Compare
asararatnakar
requested changes
Apr 5, 2024
main.go
Outdated
Comment on lines
81
to
82
| fmt.Print("Will exit Operator", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
I don't think we want to exit here.
also can we move the line 78 to post error check.
Comment on lines
+42
to
+43
| if err != nil { | ||
| fmt.Print("error initiating the logger", err) |
There was a problem hiding this comment.
we might want to fallback to other logger instead of setting nil in 118 line
shoaebjindani
force-pushed
the
operatorLogsToUTC
branch
from
0654b3b
to
889324a
Compare
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Related to hyperledger-labs#28 Signed-off-by: James Taylor <jamest@uk.ibm.com> Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
…bs#186) Signed-off-by: Ben Smith <benjsmi@us.ibm.com> Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
shoaebjindani
force-pushed
the
operatorLogsToUTC
branch
from
e0329f6
to
0c076f9
Compare
asararatnakar
approved these changes
Apr 8, 2024
shoaebjindani
added a commit
to shoaebjindani/fabric-operator
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Shoaeb Jindani <jindani.shoaeb@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.