Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing client tests #20

Closed
3 tasks done
matthiasgeihs opened this issue Jul 13, 2022 · 0 comments · Fixed by #32
Closed
3 tasks done

Add missing client tests #20

matthiasgeihs opened this issue Jul 13, 2022 · 0 comments · Fixed by #32
Labels
enhancement ✨ New feature or request test

Comments

@matthiasgeihs
Copy link
Contributor

matthiasgeihs commented Jul 13, 2022

Location

package client

Problem

We have generic tests for all the client functionality in go-perun core, but not all are used here in the Perun Ethereum Backend. In particular, the following would be important to integrate here:

  • Virtual channel happy and dispute test.
  • Subchannel happy and dispute test.
  • Failed funding test.

Proposal

Have a look at the generic client tests in go-perun and integrate them here.

@matthiasgeihs matthiasgeihs added enhancement ✨ New feature or request test labels Jul 13, 2022
@matthiasgeihs matthiasgeihs pinned this issue Jul 13, 2022
@matthiasgeihs matthiasgeihs changed the title Add client tests: Sub-channel, App channel, virtual channel Add client tests: Sub-channel, virtual channel Jul 13, 2022
@matthiasgeihs matthiasgeihs changed the title Add client tests: Sub-channel, virtual channel Add missing client tests Jul 13, 2022
@matthiasgeihs matthiasgeihs unpinned this issue Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant