Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subchannel test #21

Merged
merged 15 commits into from
Jul 21, 2022

Conversation

matthiasgeihs
Copy link
Contributor

@matthiasgeihs matthiasgeihs commented Jul 14, 2022

Adds sub-channel tests. Requires a fix to go-perun. Draft until the corresponding PR hyperledger-labs/go-perun#359 is merged there.

Relates to #20

@matthiasgeihs matthiasgeihs marked this pull request as ready for review July 15, 2022 12:26
Copy link
Member

@cryptphil cryptphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just some small suggestions.

client/init_test.go Show resolved Hide resolved
channel/conclude.go Show resolved Hide resolved
client/subchannel_test.go Outdated Show resolved Hide resolved
client/subchannel_test.go Outdated Show resolved Hide resolved
client/subchannel_test.go Outdated Show resolved Hide resolved
cryptphil
cryptphil previously approved these changes Jul 18, 2022
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
channel/funder.go Show resolved Hide resolved
client/payment_test.go Show resolved Hide resolved
client/subchannel_test.go Show resolved Hide resolved
@matthiasgeihs matthiasgeihs merged commit ff45a1c into hyperledger-labs:main Jul 21, 2022
@matthiasgeihs matthiasgeihs deleted the add-subchannel-test branch July 21, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants