Multi backend #19
Merged
Multi backend #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Is not feasible to use for multiledger tests. Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
cryptphil
force-pushed
the
multi-backend
branch
2 times, most recently
from
d5bd1bf
to
8316404
Compare
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
channel/adjudicator.go
Outdated
| @@ -54,14 +57,15 @@ type Adjudicator struct { | |||
|
|
|||
| // NewAdjudicator creates a new ethereum adjudicator. The receiver is the | |||
| // on-chain address that receives withdrawals. | |||
| func NewAdjudicator(backend ContractBackend, contract common.Address, receiver common.Address, txSender accounts.Account) *Adjudicator { | |||
| func NewAdjudicator(backend ContractBackend, chainID ChainID, contract common.Address, receiver common.Address, txSender accounts.Account) *Adjudicator { | |||
There was a problem hiding this comment.
Can we read the chainID from the Contract Backend? This removes one point of error.
There was a problem hiding this comment.
Unfortunately, we cannot get the chainID only from the ContractBackend.
There was a problem hiding this comment.
OK, in this case I think we should add it. I added a respective commit. Please check if that looks good.
Merge multiledger_happy_test.go & multiledger_dispute_test.go Review comment: Update go-perun version Review comment: Unexport FilterAssets, AssetIdx Review comment: Add Signer for SimulatedBackend Review comment: Update solc Review comment: Rename vars in assetsToEthAssets Review comment: Remove panic in AssetIDx Review comment: Fix asset equal method Review comment: Check for negative chainID when marshalling Review comment: Fix doc Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
approved these changes
Jul 19, 2022
|
Looks good to me, I'll merge! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the functionality to allow having multiple Ethereum backends.
For that, among other changes, assets need to be identified across different backends using their chainID.