Recover funds test #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
recover-funds-test
branch
from
5535f52
to
e12abd8
Compare
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Before, we filtered assets based on their ledger ID. However, this made the funder silently discard fundings if not configured correctly. Now we require to include placeholder depositors to be registered. Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
recover-funds-test
branch
from
46dec3c
to
1b83141
Compare
cryptphil
requested changes
Aug 9, 2022
Comment on lines
+353
to
+354
| // Count how often we don't expect an event because we have a zero balance or | ||
| // the asset is on a different ledger. |
There was a problem hiding this comment.
Suggested change
| // Count how often we don't expect an event because we have a zero balance or | |
| // the asset is on a different ledger. | |
| // Count how often we don't expect an event because the asset is on a different ledger or we have a zero | |
| // balance for this asset. |
There was a problem hiding this comment.
I think it's debatable which order is better :D
Honestly, I would just leave it as it is.
There was a problem hiding this comment.
Yes, but I just meant that the comment is consistent with the code because you're first checking the chains and then the zero balances. (I was first a little confused because I thought the method countDifferentLedger does both).
Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
recover-funds-test
branch
from
32ae2f5
to
73da36f
Compare
cryptphil
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We integrate the tests for fund recovery.
Depends on hyperledger-labs/go-perun#370.