Fix multi ledger #30
Merged
Fix multi ledger #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only tested the special case where funds are placed only from one side. However, in a different project we noticed that there was actually a bug when placing funds on both sides. Hence, we adapt the test setup. Signed-off-by: Matthias Geihs <matthias@perun.network>
For tests with the simulated Ethereum blockchain, we need to scale the challenge duration time because the simulated chain ticks very fast. Signed-off-by: Matthias Geihs <matthias@perun.network>
We counted the number of expected events incorrectly. Concretely, we double counted in some cases. Now changed the confirmation logic to check for the remaining required funding instead of counting events. Signed-off-by: Matthias Geihs <matthias@perun.network>
Previously, if we called Channel.Settle too early, the call would fail. This was inconvenient but not a big problem because we can just retry. However, with multi-ledger channels, the case where the conclude call arrives before it can be dispatched happens more frequently, as the different ledgers are usually not perfectly in sync. Hence, we change the conclude logic to wait on each ledger until the dispute period is over and the conclude call will succeed. Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
fix-multi-ledger
branch
from
96acacc
to
6d2b48f
Compare
cryptphil
previously approved these changes
Aug 11, 2022
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few problems with the multi-ledger funder and adjudicator. See commits messages for more details.