Fix Asset.UnmarshallBinary not working
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RmbRT
previously approved these changes
Jan 6, 2023
- The method did not have a pointer receiver and thus could not set the value, resulting in the previous (default) value instead of the just unmarshalled one. - Additionally, the order was different from `Asset.MarshallBinary`, which meant unmarshalling a value just marshalled would result in the wrong value or an error. The added test coveres both these cases. Signed-off-by: Jens Winkle <jens@perun.network>
DragonDev1906
force-pushed
the
asset-unmarshal
branch
from
e5d8fb1
to
fd8b6cf
Compare
RmbRT
approved these changes
Jan 6, 2023
DragonDev1906
added a commit
to hyperledger-labs/perun-rs
that referenced
this pull request
Mar 14, 2023
- Go: Change go-side to accept any incomming channel (and a wallet related fix) - Rust: Uncomment channel proposal and receive of accept message - Rust: Change order of values in encoded assets (Asset.MarshalBinary), see hyperledger-labs/perun-eth-backend#36 for why this wasn't correct beforehand. Additionally, this PR is required for this example to work correctly, as go-perun will throw away all proposed channels because the Asset list isn't deserialized/unmarshaled correctly. Signed-off-by: Jens <jens@perun.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asset.MarshallBinary, which meant unmarshalling a value just marshalled would result in the wrong value or an error.The added test coveres both these cases.
Signed-off-by: Jens Winkle jens@perun.network